Add registration warning popup to websocket-only users without GCM#24
Conversation
|
Well, do you want to show the warning to all users who run the websocket-reborn branch, or just those who run websocket-reborn and don't have gApps? My thinking was to warn those without gApps, because even if you're using websocket-reborn but you have gApps, all the API calls to gApp libraries will still work, so it probably won't be buggy the same way it's buggy without gApps |
|
So you want to show the warning only to those that don't have gApps, but still use Websockets for those that have gApps with issues? |
|
According to my understanding, as of the current status of this PR, that's what will happen. Non gApps/fucked up gApps users will see the warning, and people with working gApps still use websockets, but don't get any warning about strange bugs and/or issues. |
|
Closing for now |
|
Sorry this was left idle so long. If anyone feels that such a warning dialog is needed, feel free to reopen. |
|
I have created a PR, but haven't tested that. Especially interesting would be the behavior if both dialogs will be displayed. Please comment 😄 |
|
Why was this reopened/closed? I'm confused what the status is right now and what our goals are. I believe I did test your PR in #28 |
…opup Add registration warning popup to websocket-only users without GCM
2 participants
So if you look at the old way RegistrationActivity.java does this there's a race condition in the UI between the "No google play warning" and the "are you sure this is your phone number?" warning. Additionally I think its important to warn users of the websocket branch that its possible the code will be very buggy and unstable.
